Build the snap using tox, allows for python linting #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Oct 26, 2023
| KUBE_VERSION=${KUBE_VERSION} KUBE_DASHBOARD_COMMIT=${KUBE_DASHBOARD_COMMIT} CEPH_CSI_COMMIT=${CEPH_CSI_COMMIT} COREDNS_COMMIT=${COREDNS_COMMIT} OPENSTACK_PROVIDER_COMMIT=${OPENSTACK_PROVIDER_COMMIT} KUBE_STATE_METRICS_COMMIT=${KUBE_STATE_METRICS_COMMIT} K8S_DEVICE_PLUGIN_COMMIT=${K8S_DEVICE_PLUGIN_COMMIT} K8S_KEYSTONE_AUTH_IMAGE_VER=${K8S_KEYSTONE_AUTH_IMAGE_VER} ./get-addon-templates | ||
| KUBE_VERSION=${KUBE_VERSION} KUBE_DASHBOARD_COMMIT=${KUBE_DASHBOARD_COMMIT} CEPH_CSI_COMMIT=${CEPH_CSI_COMMIT} COREDNS_COMMIT=${COREDNS_COMMIT} OPENSTACK_PROVIDER_COMMIT=${OPENSTACK_PROVIDER_COMMIT} KUBE_STATE_METRICS_COMMIT=${KUBE_STATE_METRICS_COMMIT} K8S_DEVICE_PLUGIN_COMMIT=${K8S_DEVICE_PLUGIN_COMMIT} K8S_KEYSTONE_AUTH_IMAGE_VER=${K8S_KEYSTONE_AUTH_IMAGE_VER} tox -e fetch |
There was a problem hiding this comment.
first start here -- but i envision this entire makefile can be done away with in the future and replaced with tox.ini
There was a problem hiding this comment.
💯 I like the idea of replacing the Makefile with tox.
mateoflorido
approved these changes
Oct 26, 2023
| KUBE_VERSION=${KUBE_VERSION} KUBE_DASHBOARD_COMMIT=${KUBE_DASHBOARD_COMMIT} CEPH_CSI_COMMIT=${CEPH_CSI_COMMIT} COREDNS_COMMIT=${COREDNS_COMMIT} OPENSTACK_PROVIDER_COMMIT=${OPENSTACK_PROVIDER_COMMIT} KUBE_STATE_METRICS_COMMIT=${KUBE_STATE_METRICS_COMMIT} K8S_DEVICE_PLUGIN_COMMIT=${K8S_DEVICE_PLUGIN_COMMIT} K8S_KEYSTONE_AUTH_IMAGE_VER=${K8S_KEYSTONE_AUTH_IMAGE_VER} ./get-addon-templates | ||
| KUBE_VERSION=${KUBE_VERSION} KUBE_DASHBOARD_COMMIT=${KUBE_DASHBOARD_COMMIT} CEPH_CSI_COMMIT=${CEPH_CSI_COMMIT} COREDNS_COMMIT=${COREDNS_COMMIT} OPENSTACK_PROVIDER_COMMIT=${OPENSTACK_PROVIDER_COMMIT} KUBE_STATE_METRICS_COMMIT=${KUBE_STATE_METRICS_COMMIT} K8S_DEVICE_PLUGIN_COMMIT=${K8S_DEVICE_PLUGIN_COMMIT} K8S_KEYSTONE_AUTH_IMAGE_VER=${K8S_KEYSTONE_AUTH_IMAGE_VER} tox -e fetch |
There was a problem hiding this comment.
💯 I like the idea of replacing the Makefile with tox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a
tox.ini, we can format and lint the python pieces of this package.Similarly, we can specify the python packages required to build the snap (currently just pyyaml)